Bug #70
Makefiles do not respect environmental CFLAGS
0%
Description
Convention is to use CFLAGS += ... in Makefiles so that users can pass additional arguments via the command line. The current Makefiles all use CFLAGS =
Motivated by trying to get this to build on OS X and "CFLAGS=-I/usr/local/opt/openssl/include -L/usr/local/opt/openssl/lib make" failing.
History
#1 Updated by Eric Allman over 6 years ago
- Status changed from New to Resolved
- Assignee set to Eric Allman
Fixed in commit:f5c1552e. Sorry something this simple took so long. Please verify that it's fixed for you.
#2 Updated by Pat Pannuto over 6 years ago
Eric Allman wrote:
Fixed in commit:f5c1552e. Sorry something this simple took so long. Please verify that it's fixed for you.
No worries -- work-aroundable build issues aren't exactly top priority the week before the demo :D
CFLAGS is fixed, but I noticed two other issues:
LDFLAGS should be += for the same reasons
The submake invocations should use $(MAKE) instead of naked make (see https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable)
#3 Updated by Eric Allman over 6 years ago
These other problems should have been resolved in commit:6cc67fbe.
#4 Updated by Eric Allman over 6 years ago
- Status changed from Resolved to Closed